Convert errors thrown from interceptor inbound or outbound stream #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Jun 16, 2025
Sources/GRPCCore/Call/Client/Internal/ClientStreamExecutor.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCCoreTests/Call/Server/Internal/ServerRPCExecutorTests.swift
Outdated
Show resolved
Hide resolved
|
The "Check generated code" check will be fixed by #4 |
bauer-andreas
force-pushed
the
rpc-convertible-support-interceptors
branch
from
ae9a5f2 to
5f26c53
Compare
glbrntt
requested changes
Jun 18, 2025
glbrntt
approved these changes
Jun 18, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Aug 26, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `grpc-swift-2` to 2.1.0. ### Why are the changes needed? To bring the latest improvements and bug fixes. - https://github.com/grpc/grpc-swift-2/releases/tag/2.1.0 - grpc/grpc-swift-2#4 - grpc/grpc-swift-2#3 - grpc/grpc-swift-2#7 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #231 from dongjoon-hyun/SPARK-52913. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
RPCConvertibleerrors are properly converted when thrown as part of theinterceptmethod, errors thrown from within theproducerclosures or as part of the message sequences are not being converted.This PR resolves that and adds the necessary unit tests to verify that.