Skip to content

Conversation

@gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Jan 24, 2025

No description provided.

@gjcairo gjcairo added the semver/none No version bump required. label Jan 24, 2025
@gjcairo gjcairo requested a review from glbrntt January 24, 2025 14:21
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of nits and you'll also need to update .spi.yml.

@gjcairo gjcairo requested a review from glbrntt January 24, 2025 14:36
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, thanks!

@glbrntt glbrntt merged commit 869fe81 into grpc:main Jan 24, 2025
21 checks passed
@gjcairo gjcairo deleted the doc-bundles branch January 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants