Skip to content

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Nov 5, 2024

Motivation:

  • Reduce duplication
  • Centralise boilerplate changes when new Swift versions are picked up.
  • Benefit from centralised work to add new linting / test infrastructure.

Modifications:

Changes of note:

  • Use soundness checks from swiftlang/github-workflows.
  • Retain bespoke license-checking code for .swift files as the gRPC header style is very different to most templates.

Result:

More test, linting, formatting coverage. More common CI with other Swift on Server projects.

@rnro rnro added 🆕 semver/minor Adds new public API. 🔨 semver/patch No public API change. and removed 🆕 semver/minor Adds new public API. labels Nov 5, 2024
@rnro rnro requested a review from glbrntt November 6, 2024 09:33
@rnro rnro force-pushed the adopt_standardized_github_actions branch 2 times, most recently from a27b68e to 2b7fbe7 Compare November 7, 2024 08:38
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @rnro

@glbrntt glbrntt enabled auto-merge (squash) November 7, 2024 12:57
Motivation:

* Reduce duplication
* Centralise boilerplate changes when new Swift versions are picked up.
* Benefit from centralised work to add new linting / test
  infrastructure.

Modifications:

Changes of note:
* Use soundness checks from swiftlang/github-workflows.
* Retain bespoke license-checking code for .swift files as the gRPC
  header style is very different to most templates.

Result:

More test, linting, formatting coverage. More common CI with other Swift
on Server projects.
@rnro rnro force-pushed the adopt_standardized_github_actions branch from 2b7fbe7 to 960a32c Compare November 7, 2024 12:59
@glbrntt glbrntt merged commit c7ab0b3 into main Nov 7, 2024
26 of 28 checks passed
@glbrntt glbrntt deleted the adopt_standardized_github_actions branch November 7, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants