Don't generate reflection data. #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: v1 generated reflection data via the protoc plugin; this wasn't remvoed from v2 but the v2 reflection servcice doesn't use data in the same format. Instead, v2 expects users to invoke protoc directly to generate a descriptor set. This makes the option redundant: it can be called but the output can't be used. Modifications: - Remove the reflection data generating code and have the option throw an error. Result: Less code
gjcairo
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
v1 generated reflection data via the protoc plugin; this wasn't remvoed from v2 but the v2 reflection servcice doesn't use data in the same format. Instead, v2 expects users to invoke protoc directly to generate a descriptor set. This makes the option redundant: it can be called but the output can't be used.
Modifications:
Result:
Less code