Skip to content

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Mar 5, 2025

Motivation:

The command plugin needs to be a product in order for it to be used.

Modifications:

  • Add it to the products
  • Give it the same name as the command, otherwise diagnostics (like SwiftPM asking for permission to write to the package dir) will use a different name which isn't obvious.
  • Fix a few build warnings.

Result:

  • Command plugin can be used

Motivation:

The command plugin needs to be a product in order for it to be used.

Modifications:

- Add it to the products
- Give it the same name as the command, otherwise diagnostics (like
  SwiftPM asking for permission to write to the package dir) will use a
  different name which isn't obvious.
- Fix a few build warnings.

Result:

- Command plugin can be used
@glbrntt glbrntt requested a review from rnro March 5, 2025 17:37
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Mar 5, 2025
@glbrntt glbrntt enabled auto-merge (squash) March 5, 2025 17:38
@glbrntt glbrntt merged commit 63982ca into grpc:main Mar 5, 2025
26 checks passed
@glbrntt glbrntt deleted the make-command-plugin-a-product branch March 5, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants