Skip to content

Conversation

ethanndickson
Copy link
Contributor

This line is also present on files generated by swift-protobuf.

Copy link

linux-foundation-easycla bot commented Mar 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ethanndickson / name: Ethan (a7dc8ab, b18ebe5)
  • ✅ login: glbrntt / name: George Barnett (613d07f)

@ethanndickson
Copy link
Contributor Author

ethanndickson commented Mar 6, 2025

For context, swiftlint doesn't have proper support for excluding files with a certain extension: realm/SwiftLint#2329, making this PR useful.

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Mar 17, 2025
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ethanndickson -- and thanks for providing the context too.

Could you run ./dev/protos/generate.sh? That'll make re-generate the code checked in to this repo with your changes.

@ethanndickson
Copy link
Contributor Author

Done!

@ethanndickson ethanndickson requested a review from glbrntt March 18, 2025 04:33
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@glbrntt glbrntt enabled auto-merge (squash) March 18, 2025 10:45
@glbrntt glbrntt merged commit 49bdd12 into grpc:main Mar 18, 2025
25 of 27 checks passed
@adarhef
Copy link

adarhef commented May 18, 2025

Hey, just wanted to comment that if I don't exclude pb files from analysis, SwiftLint warns about blanket disable commands:

Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'all' rule once, or re-enable it as soon as possible` (blanket_disable_command)

The blanket_disable_command rule is enabled by default in SwiftLint, and I personally prefer to keep it enabled.
I think we might want to swiftlint:enable all at the end of the file to get around this?

EDIT: I just noticed the swift-protobuf generator doesn't re-enable warnings at the end either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants