Only import SwiftProtobuf when WKTs are used as input/output #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification: The code generator imports SwiftProtobuf if the file being generated has a dependency on any of the protos bundled by SwiftProtobuf. This can yield unnecessary imports which may warn if used in conjunction with access levels on imports. The problem is that the grpc generator checks for dependencies on the FileDescriptor which may include messages defined in the same file as a service. If any of those messages depend on a well known type (WKT) then an import will be added even though the code being generated doesn't include message code. Modifications: - Only include a SwiftProtobuf import if an input or output type for an RPC is a bundled proto. - Fix a test where a WKT is used in a message but not as an input/output type for an RPC. Result: Fewer warnings
gjcairo
approved these changes
Aug 19, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Oct 1, 2025
…gen-grpc-swift-2 v2.1.1 ### What changes were proposed in this pull request? This PR aims to regenerate `Spark Connect`-generated Swift source code with `protoc-gen-grpc-swift-2` v2.1.1 from apache/spark@c165355. Previously, it was generated by `2.0.0` from apache/spark@c165355 . - #205 (2025-06-30) ### Why are the changes needed? Without changing the Spark protobuf files, this PR only applies code-generation bug fixes including concurrency patches: - https://formulae.brew.sh/formula/protoc-gen-grpc-swift - https://github.com/grpc/grpc-swift-protobuf/releases/tag/2.1.0 - grpc/grpc-swift-protobuf#77 - grpc/grpc-swift-protobuf#85 - https://github.com/grpc/grpc-swift-protobuf/releases/tag/2.1.1 - grpc/grpc-swift-protobuf#86 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #249 from dongjoon-hyun/SPARK-53774. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification:
The code generator imports SwiftProtobuf if the file being generated has a dependency on any of the protos bundled by SwiftProtobuf. This can yield unnecessary imports which may warn if used in conjunction with access levels on imports.
The problem is that the grpc generator checks for dependencies on the FileDescriptor which may include messages defined in the same file as a service. If any of those messages depend on a well known type (WKT) then an import will be added even though the code being generated doesn't include message code.
Modifications:
Result:
Fewer warnings