Adopt Mutex where possible
#2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Swift 6 has a `Mutex` which we can use in place of `LockedValueBox` or `NIOLockedValueBox` in a bunch of places. Modifications: - Use `Mutex` where possible - This causes a number of other changes too as `Mutex` doesn't allocate: the allocations move to the type holding it instead. This makes sense as the objects which were previously structs didn't have value semantics. Result: Fewer uses of our own lock, no uses of NIOs lock
gjcairo
requested changes
Aug 27, 2024
Sources/GRPCHTTP2Core/Client/Connection/LoadBalancers/RoundRobinLoadBalancer.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2Core/Client/Connection/LoadBalancers/PickFirstLoadBalancer.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport+Posix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOTransportServices/HTTP2ServerTransport+TransportServices.swift
Outdated
Show resolved
Hide resolved
gjcairo
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 6 has a
Mutexwhich we can use in place ofLockedValueBoxorNIOLockedValueBoxin a bunch of places.Modifications:
Mutexwhere possibleMutexdoesn't allocate: the allocations move to the type holding it instead. This makes sense as the objects which were previously structs didn't have value semantics.Result:
Fewer uses of our own lock, no uses of NIOs lock