Add a design doc #2079
Merged
Add a design doc #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: For library maintainers and some users, having an understanding of how the library is structured is incredibly helpful. Modifications: - Add a high-level design doc linking to the relevant symbols - Fix up a couple of other DocC warnings Result: More docs
gjcairo
requested changes
Oct 3, 2024
| doing this doesn't leave the other side waiting indefinitely. | ||
|
|
||
| gRPC has mechanisms to deliver method-specific configuration at the transport | ||
| layer which can also change dynamically (see "gRFC A2: ServiceConfig in DNS".) |
There was a problem hiding this comment.
Should we link to the RFC?
There was a problem hiding this comment.
Yes, good idea, I'll add this.
| task from which all accepted streams are run under. Much like the client, you | ||
| can initiate graceful shutdown by calling ``GRPCServer/beginGracefulShutdown()`` | ||
| which will stop new RPCs from being handled but will let existing RPCs run to | ||
| completion. |
There was a problem hiding this comment.
Should we mention, like under Client, that the server can be stopped abruptly by cancelling the task in which serve is running?
Co-authored-by: Gus Cairo <[email protected]>
gjcairo
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For library maintainers and some users, having an understanding of how the library is structured is incredibly helpful.
Modifications:
Result:
More docs