Skip to content

Add a design doc #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Add a design doc #2079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
073c95f
Add a design doc
glbrntt Sep 19, 2024
8ca6c73
Apply suggestions from code review
glbrntt Oct 3, 2024
5eed4d2
add link and note about cancellation
glbrntt Oct 3, 2024
171d29e
Merge branch 'main' into v2/design-doc
gjcairo Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/GRPCCore/Call/Client/ClientRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
/// See ``StreamingClientRequest`` for streaming requests and ``ServerRequest`` for the
/// servers representation of a single-message request.
///
/// ## Creating ``Single`` requests
/// ## Creating requests
///
/// ```swift
/// let request = ClientRequest<String>(message: "Hello, gRPC!")
Expand Down
4 changes: 2 additions & 2 deletions Sources/GRPCCore/Call/Client/ClientResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/// an ``RPCError`` describing why the RPC failed, including an error code, error message and any
/// metadata sent by the server.
///
/// ### Using ``Single`` responses
/// ### Using responses
///
/// Each response has a ``accepted`` property which contains all RPC information. You can create
/// one by calling ``init(accepted:)`` or one of the two convenience initializers:
Expand Down Expand Up @@ -153,7 +153,7 @@ public struct ClientResponse<Message: Sendable>: Sendable {
/// to execute the request. The failure case contains an ``RPCError`` describing why the RPC
/// failed, including an error code, error message and any metadata sent by the server.
///
/// ### Using ``Stream`` responses
/// ### Using streaming responses
///
/// Each response has a ``accepted`` property which contains RPC information. You can create
/// one by calling ``init(accepted:)`` or one of the two convenience initializers:
Expand Down
4 changes: 2 additions & 2 deletions Sources/GRPCCore/Call/Server/ServerResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/// of the RPC failed. The failure case contains an ``RPCError`` describing why the RPC failed,
/// including an error code, error message and any metadata sent by the server.
///
/// ### Using ``Single`` responses
/// ### Using responses
///
/// Each response has an ``accepted`` property which contains all RPC information. You can create
/// one by calling ``init(accepted:)`` or one of the two convenience initializers:
Expand Down Expand Up @@ -144,7 +144,7 @@ public struct ServerResponse<Message: Sendable>: Sendable {
/// contains an ``RPCError`` describing why the RPC failed, including an error code, error
/// message and any metadata to send to the client.
///
/// ### Using ``Stream`` responses
/// ### Using streaming responses
///
/// Each response has an ``accepted`` property which contains all RPC information. You can create
/// one by calling ``init(accepted:)`` or one of the two convenience initializers:
Expand Down
Loading
Loading