Add a merge method to Metadata #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
commented
Oct 6, 2024
gjcairo
force-pushed
the
merge-metadata
branch
from
2dbd83c to
92ea6a3
Compare
gjcairo
force-pushed
the
merge-metadata
branch
from
92ea6a3 to
94b4643
Compare
glbrntt
requested changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to be able to flatten
RPCErrors, and to do so we need to be able to merge theMetadatacontained in each.Modifications
This PR adds a helper function to merge one
Metadatainstance into another.Result
Unblocks #2083 and also provides a potentially useful API for users.
- Note: Because of the way
Metadatahas been implemented, we can have multiple identical key-value pairs. This isn't ideal, as it's particularly feasible that we'll end up with multiple repeated identical pairs when merging twoMetadatas. I think we should reconsider the backing data structure (using a set for example) or add a check before inserting to avoid this.