Skip to content

Remove guarded declarations case in generated code #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove guarded declarations case in generated code #2138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Sources/GRPCCodeGen/Internal/Renderer/TextBasedRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,8 +857,6 @@ struct TextBasedRenderer: RendererProtocol {
renderCommentableDeclaration(comment: comment, declaration: nestedDeclaration)
case let .deprecated(deprecation, nestedDeclaration):
renderDeprecatedDeclaration(deprecation: deprecation, declaration: nestedDeclaration)
case let .guarded(availability, nestedDeclaration):
renderGuardedDeclaration(availability: availability, declaration: nestedDeclaration)
case .variable(let variableDescription): renderVariable(variableDescription)
case .extension(let extensionDescription): renderExtension(extensionDescription)
case .struct(let structDescription): renderStruct(structDescription)
Expand Down
7 changes: 0 additions & 7 deletions Sources/GRPCCodeGen/Internal/StructuredSwiftRepresentation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,9 +791,6 @@ indirect enum Declaration: Equatable, Codable, Sendable {
/// A declaration that adds a comment on top of the provided declaration.
case deprecated(DeprecationDescription, Declaration)

/// A declaration that adds an availability guard on top of the provided declaration.
case guarded(AvailabilityDescription, Declaration)

/// A variable declaration.
case variable(VariableDescription)

Expand Down Expand Up @@ -1870,7 +1867,6 @@ extension Declaration {
switch self {
case .commentable(_, let declaration): return declaration.accessModifier
case .deprecated(_, let declaration): return declaration.accessModifier
case .guarded(_, let declaration): return declaration.accessModifier
case .variable(let variableDescription): return variableDescription.accessModifier
case .extension(let extensionDescription): return extensionDescription.accessModifier
case .struct(let structDescription): return structDescription.accessModifier
Expand All @@ -1889,9 +1885,6 @@ extension Declaration {
case .deprecated(let deprecationDescription, var declaration):
declaration.accessModifier = newValue
self = .deprecated(deprecationDescription, declaration)
case .guarded(let availability, var declaration):
declaration.accessModifier = newValue
self = .guarded(availability, declaration)
case .variable(var variableDescription):
variableDescription.accessModifier = newValue
self = .variable(variableDescription)
Expand Down
Loading