Skip to content

Use a nil Descriptor list for empty proto files #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Use a nil Descriptor list for empty proto files #2152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/GRPCCodeGen/Internal/Translator/IDLToStructuredSwiftTranslator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ package struct IDLToStructuredSwiftTranslator: Translator {
}
}

let imports: [ImportDescription]
let imports: [ImportDescription]?
if codeGenerationRequest.services.isEmpty {
imports = []
imports = nil
codeBlocks.append(
CodeBlock(comment: .inline("This file contained no services."))
)
Expand Down
1 change: 0 additions & 1 deletion ...RPCCodeGenTests/Internal/Translator/IDLToStructuredSwiftTranslatorSnippetBasedTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ final class IDLToStructuredSwiftTranslatorSnippetBasedTests: XCTestCase {
"""
/// Some really exciting license header 2023.


// This file contained no services.
"""
try self.assertIDLToStructuredSwiftTranslation(
Expand Down
Loading