Deduplicate interceptor pipeline operation #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ClientInterceptorPipelineOperation is the same as ServerInterceptorPipelineOperation apart from the type of interceptor being used. The duplication here is unnecessary. Modifications: - Add a `ConditionalInterceptor` which is roughly the same as `*InterceptorPipelineOperation` but is generic. - The init is private and can only be initialized via static methods when the generic type is appropriate (i.e. client/server interceptor). Result: Less duplication, less code
glbrntt
changed the title
gjcairo
reviewed
Jan 16, 2025
gjcairo
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ClientInterceptorPipelineOperation is the same as
ServerInterceptorPipelineOperation apart from the type of interceptor being used. The duplication here is unnecessary.
Modifications:
ConditionalInterceptorwhich is roughly the same as*InterceptorPipelineOperationbut is generic.Result:
Less duplication, less code