Add remote and local peers to ServerContext
#2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Jan 16, 2025
glbrntt
approved these changes
Jan 16, 2025
|
This API break is expected: the local peer is required so we can't not have it as part of the context's initialiser. |
gjcairo
added
⚠️ semver/major
|
Also @glbrntt you'll have to merge this to override the failing required step |
glbrntt
pushed a commit
to grpc/grpc-swift-nio-transport
that referenced
this pull request
Jan 17, 2025
This PR adopts the changes introduced in grpc/grpc-swift#2161.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
localPeerproperty to theServerContext, and renamespeertoremotePeer.This is related to #2158 on the client side and will be used to improve the server tracing interceptor.