Skip to content

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 22, 2025

Motivation:

We now have a SwiftPM build plugin to generate code as part of the build
process, the examples should make use of it.

Modifications:

  • Remove generated code for examples and update the generate script to
    stop genearting example code.
  • Symlink protos from examples to the checked out location in the repo;
    this avoids some duplication and makes it easier to keep things
    up-to-date.
  • Add a basic config to each example.
  • Update CI to install protoc before building examples.

Result:

Better examples, less code.

Motivation:

We now have a SwiftPM build plugin to generate code as part of the build
process, the examples should make use of it.

Modifications:

- Remove generated code for examples and update the generate script to
  stop genearting example code.
- Symlink protos from examples to the checked out location in the repo;
  this avoids some duplication and makes it easier to keep things
  up-to-date.
- Add a basic config to each example.
- Update CI to install protoc before building examples.

Result:

Better examples, less code.
@glbrntt glbrntt added the semver/none No version bump required. label Jan 22, 2025
Copy link
Collaborator

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@glbrntt glbrntt marked this pull request as ready for review January 22, 2025 17:11
@glbrntt glbrntt enabled auto-merge (squash) January 22, 2025 17:11
@glbrntt glbrntt merged commit 9639fe9 into grpc:main Jan 22, 2025
27 of 29 checks passed
@rnro rnro mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants