-
Notifications
You must be signed in to change notification settings - Fork 434
Update tutorials to use the build plugin #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,11 +29,16 @@ | |
Let's start by running the existing Greeter application. | ||
|
||
As a prerequisite you must have the Protocol Buffers compiler (`protoc`) installed. You can | ||
find the instructions for doing this in the [gRPC Swift Protobuf | ||
find the instructions for doing this in the [gRPC Swift Protobuf | ||
documentation](https://swiftpackageindex.com/grpc/grpc-swift-protobuf/documentation/grpcprotobuf/installing-protoc). | ||
The remainder of this tutorial assumes you installed `protoc` and it's available in | ||
your `$PATH`. | ||
|
||
You may notices that the `swift` commands are all prefixed with `PROTOC_PATH=$(which protoc)`, | ||
gjcairo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
this is to let the build system know where `protoc` is located so that it can generate stubs | ||
for you. You can read more about it in the [gRPC Swift Protobuf | ||
documentation](https://swiftpackageindex.com/grpc/grpc-swift-protobuf/documentation/grpcprotobuf/generating-stubs). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that this is a pre-emptive change: I think we should move the generating stubs doc to the protobuf package and then link to it from the core package docs. |
||
|
||
@Steps { | ||
@Step { | ||
In a terminal run `PROTOC_PATH=$(which protoc) swift run hello-world serve` to start the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we explain why There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah that's a great point, I'll do that. |
||
|
Uh oh!
There was an error while loading. Please reload this page.