Display control chars and invisible Unicode explicitly (#220)#228
Open
AJTimePyro wants to merge 2 commits intogruns:masterfrom
Open
Display control chars and invisible Unicode explicitly (#220)#228AJTimePyro wants to merge 2 commits intogruns:masterfrom
AJTimePyro wants to merge 2 commits intogruns:masterfrom
Conversation
Collaborator
|
Thank you! That looks promising! I'll take a look. |
Author
|
cool, let me know if there's any issue or something,... i will change accordingly |
Collaborator
|
@AJTimePyro I think it would be nice to have test covered this one. Do you think you could do that? Keep in mind, that recently I merged tests refactoring (in PEP8 style). |
Author
|
I can try to create some test |
Author
|
@Jakeroid I have added some tests, you can check them out. |
Collaborator
|
@AJTimePyro Tests are failed. Could you take a look please? |
Collaborator
|
@AJTimePyro Oh, I know why. Because of recent refactoring which was did here: #223 Do you think you could fix issues by keeping refactoring in place? |
Author
|
oh okay i will fix it soon |
Collaborator
|
@AJTimePyro awesome thank you! |
Collaborator
|
@AJTimePyro How is it going? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how
argumentToStringconverts strings by making escaping safer and more predictable, especially for edge cases that were previously mishandled. Inspired from issue #220What changed: