Add static analysis with golangci-lint to prevent nil pointer exceptions #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james00012
force-pushed
the
feat/add-static-analysis
branch
4 times, most recently
from
0052d25 to
d3cd760
Compare
Add golangci-lint for static analysis to prevent nil pointer exceptions and other common Go bugs. Changes: - Configure golangci-lint with focus on nil safety (errcheck, nilnil, nilerr, staticcheck) - Add lint job to CircleCI pipeline that runs before tests - Create Makefile for local development workflow - Add GitHub Actions workflow as alternative CI - Update pre-commit hooks to include linting - Document static analysis setup and best practices This addresses recent nil pointer issues by catching them at build time before they reach production.
james00012
force-pushed
the
feat/add-static-analysis
branch
from
d3cd760 to
bb3b92d
Compare
Remove duplicate 'new' key at line 93 that was conflicting with the existing 'new: true' setting at line 65. This fixes the YAML parsing error that was preventing golangci-lint from running.
denis256
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add golangci-lint to catch nil pointer dereferences at build time. Configured to check only new/modified code for gradual adoption.
Motivation
Recent PRs show multiple nil pointer fixes (#904, #903). This adds automated checks to prevent these issues.
Changes
.golangci.yml: Configure linters focused on nil safety (staticcheck, errcheck, nilnil, nilerr)Test Plan
--new-from-rev=origin/master)