refactor: migrate 30 more AWS resources to generic Resource[C] pattern#987
Merged
james00012 merged 1 commit intomasterfrom Jan 1, 2026
Merged
refactor: migrate 30 more AWS resources to generic Resource[C] pattern#987james00012 merged 1 commit intomasterfrom
james00012 merged 1 commit intomasterfrom
Conversation
james00012
changed the title
james00012
force-pushed
the
feat/generic-resource-aws
branch
from
5928611 to
f56d668
Compare
james00012
changed the title
james00012
force-pushed
the
feat/generic-resource-aws
branch
2 times, most recently
from
32e2e83 to
21aa80f
Compare
Migrates resources from legacy BaseAwsResource to generic Resource[C]: - Consolidates *_types.go files into main resource files - Uses factory functions (NewXxx) instead of struct instantiation - Standardizes tests with table-driven patterns
james00012
force-pushed
the
feat/generic-resource-aws
branch
from
21aa80f to
3f8b32c
Compare
denis256
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseAwsResourceto genericResource[C]pattern*_types.gofiles into main resource filesNewXxx()) instead of struct instantiationNew Resources Migrated (30)
ACM, ACMPCA, AMIs, AppRunnerService, BackupVault, CloudtrailTrail, CloudWatchAlarms, ConfigRecorders, DataSyncLocation, DataSyncTask, DynamoDB, EBApplications, ECR, EIPAddresses, EventBridgeArchive, Grafana, GuardDuty, LaunchTemplates, ManagedPrometheus, NatGateways, RdsProxy, RdsSnapshot, SecretsManagerSecrets, SesConfigurationSet, SesIdentities, Snapshots, SNSTopic, SqsQueue, TransitGatewayPeeringAttachment, TransitGatewayRouteTables
Test Plan