add possibility to setup a custom logger for kubectl configuration#1384
Open
lahabana wants to merge 2 commits intogruntwork-io:mainfrom
Open
add possibility to setup a custom logger for kubectl configuration#1384lahabana wants to merge 2 commits intogruntwork-io:mainfrom
lahabana wants to merge 2 commits intogruntwork-io:mainfrom
Conversation
Contributor
Author
|
@denis256 any chance to get that in? |
denis256
reviewed
Mar 18, 2024
| RestConfig *rest.Config | ||
| Logger *logger.Logger | ||
| // ConfigLogger is useful to set a different logger when configuring kubectl with a config. This can significantly reduce verbosity of tests | ||
| ConfigLogger *logger.Logger |
Member
There was a problem hiding this comment.
Hm, what will happen if the logger will not be provided?
Contributor
Author
There was a problem hiding this comment.
The logger falls back to the Default logger if it's nil. This also enables backward compatibility
terratest/modules/logger/logger.go
Lines 63 to 70 in 6fb8605
Contributor
Author
|
@denis256 sorry I didn't notice you commented on the PR. |
This enables users to not log messages like: "Configuring Kubernetes client using config file" Fix gruntwork-io#1383 Signed-off-by: Charly Molter <charly.molter@konghq.com>
Contributor
Author
|
@denis256 friendly ping on this :) It would greatly help our test logs to be a lot more readable :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1383.
This enables users to not log messages like: "Configuring Kubernetes client using config file"
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added option
ConfigLoggerinKubectlOptionsto specify a custom logger for configurationMigration Guide