Skip to content

Comments

fix informloci quiet mode#267

Merged
zkamvar merged 8 commits intomainfrom
znk/fix-informloci/266
Aug 9, 2025
Merged

fix informloci quiet mode#267
zkamvar merged 8 commits intomainfrom
znk/fix-informloci/266

Conversation

@zkamvar
Copy link
Member

@zkamvar zkamvar commented Aug 9, 2025

There was a bug in informloci if you used quiet = TRUE, it would error because the message function was missing an argument.

I fixed it by removing that argument and calculating it within the messenger. I also added a few housekeeping items:

  • change ifelse to if else
  • clean up the syntax with lintr

This will fix #266

@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (0555de5) to head (fb6acaa).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   93.80%   93.88%   +0.07%     
==========================================
  Files          36       36              
  Lines        5621     5628       +7     
==========================================
+ Hits         5273     5284      +11     
+ Misses        348      344       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zkamvar zkamvar mentioned this pull request Aug 9, 2025
@zkamvar zkamvar merged commit 23783b1 into main Aug 9, 2025
5 of 9 checks passed
@zkamvar zkamvar deleted the znk/fix-informloci/266 branch August 9, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in informloci()

1 participant