Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an end-to-end acceptance test to the posenet-tf crate so the exposed DEEPaaS service can be validated automatically through oscar-cli hub validate.
The RO-Crate for [crates/posenet-tf/ro-crate-metadata.json] now defines a structured exposed HTTP acceptance step. The test uploads a real sample image to /v2/models/posenetclas/predict/ using service Basic Auth and asserts that the response is a valid ZIP archive. The crate metadata was also updated to reference the new sample input and acceptance artifacts.
Validation performed:
npm run build
live acceptance run against the deployed service:
go run . hub validate posenet-tf --local-path oscar-hub/crates/posenet-tf -c localhost-oidc-grycap -n body-pose
result: pass
User-facing impact:
posenet-tf now has a reproducible acceptance test for its exposed API, not just metadata and deployment files
the test reflects the real supported workflow: authenticated multipart image upload returning a ZIP result.
This requires PR grycap/oscar-cli#79 integrated in OSCAR-CLI to be tested via
oscar-cli hub validate