Skip to content

View-Mode: Improve user experience of code blocks #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsantner merged 19 commits into from
Jan 8, 2026
Merged

View-Mode: Improve user experience of code blocks #2698

gsantner merged 19 commits into from
Jan 8, 2026

Conversation

@guanglinn
Copy link
Contributor

@guanglinn guanglinn commented Nov 28, 2025 •
edited
Loading

Improve user experience of code blocks in view mode:

  • Fix line numbers display error in long wrapping words
  • Auto-refresh line numbers when font size was changed
  • Switch line numbers is available
  • Switch wrap words is available
  • Tweak paddings
  • Add Visual Basic syntax highlight
  • Add Zig syntax highlight

#2697

@guanglinn
Copy link
Contributor Author

guanglinn commented Nov 28, 2025 •
edited
Loading

2025-11-28-prism-line-numbers-layout-error 2025-11-28-prism-line-numbers-layout-fixed

Left: line numbers display errors in long wrapping words.
Right: fixed.

@gsantner
Copy link
Owner

gsantner commented Nov 28, 2025

Are there many prismjs (official) definitions not in Markor?
I initially wanted to keep it slim and most important ones, but at this point seems like we have most of the available ones already.

@guanglinn guanglinn changed the title Add Visual Basic language highlighting for Prism.js Fix line numbers layout errors for large scale wrapping words in view mode Nov 28, 2025
@guanglinn
Copy link
Contributor Author

guanglinn commented Nov 28, 2025 •
edited
Loading

Yes, there are too many official supported languages. https://prismjs.com/download

I also think it may be already enough for the languages we have added. app/thirdparty/assets/prism/components

Fortunately, these files are very small, about 1.5KB per file.

@guanglinn guanglinn changed the title Fix line numbers layout errors for large scale wrapping words in view mode Fix line numbers layout error for large scale wrapping words in view mode Nov 30, 2025
@guanglinn guanglinn changed the title Fix line numbers layout error for large scale wrapping words in view mode Fix line numbers layout error for long wrapping words in view mode Nov 30, 2025
@guanglinn guanglinn changed the title Fix line numbers layout error for long wrapping words in view mode View-Mode: Fix line numbers layout error in long wrapping words Dec 7, 2025
@guanglinn guanglinn changed the title View-Mode: Fix line numbers layout error in long wrapping words View-Mode: Improve user experience of code blocks Dec 11, 2025
@gsantner gsantner added this to the Markor v2.16 milestone Jan 8, 2026
@gsantner gsantner linked an issue Jan 8, 2026 that may be closed by this pull request
VBA code is not being syntax-highlighted properly #2697
Closed
4 tasks
gsantner
gsantner approved these changes Jan 8, 2026
View reviewed changes
Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I tried it and it works, though no noticeable difference here

@gsantner gsantner merged commit 3964129 into gsantner:master Jan 8, 2026
1 check passed
@guanglinn guanglinn deleted the prism_vb branch January 8, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsantner gsantner gsantner approved these changes

Assignees

@guanglinn guanglinn

Labels

enhancement

Projects

None yet

Milestone

Markor v2.16

Development

Successfully merging this pull request may close these issues.

VBA code is not being syntax-highlighted properly

2 participants

@guanglinn @gsantner