-
Notifications
You must be signed in to change notification settings - Fork 442
More modern material UI #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More modern material UI #2703
Conversation
|
In a subsequent PR, I may add an option to make the UI colours follow the editor colours. (so fully solarized will be possible) |
| dopt.isSearchEnabled = false; | ||
| dopt.dialogWidthDp = WindowManager.LayoutParams.WRAP_CONTENT; | ||
| dopt.dialogHeightDp = 475; | ||
| dopt.positionCallback = (result) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guanglinn I have addressed handling none priority mapping to a single letter here.
I do this by checking index (0 = remove)
Should be more robust with this approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I closed that PR #2704
|
@gsantner This is now ready for resting and review. All feedback is appreciated. |
|
Hello @harshad1 Thank you, overall the PR is fine and a good improvement! However - in dark mode, please restore the blueish-black color at toolbar and bottom navigation.
and in light mode, please restore
I prefer Markor to stay and not to be pure white / black / gray based UI. |
|
Thanks for the review. I'll make changes. For reference I picked the lightest grey and the darkest white which are still considered compatible with the material design spec. Even with these changes Markor is still considerably softer than other apps I referred to (thunderbird, gmail etc etc). I will make it softer still. |
|
This branch ended up being too hard to work in. I created a new branch with more streamlined changes. Opening a new PR with the same intent |


In this PR I have adjusted the colours and some UI elements in Markor to more closely match the material guidelines.
Per @gsantner's request I have reverted to using 'primaryColor' for the light mode top bar. Material design guidelines say that dark mode should have a dark bar and I also think this looks way better so I have kept this