Skip to content

fixed typo: delataPan -> deltaPan #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed typo: delataPan -> deltaPan #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17ec723
fixed typo: delataPan -> deltaPan
adamnemecek Jun 14, 2020
0bace35
fixed delatapan in the cpp file
adamnemecek Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Code/Camera.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,13 @@ void OrbitCamera::Zoom(float deltaZoom, float deltaTime) {
}
}

void OrbitCamera::Pan(const vec2& delataPan, float deltaTime) {
void OrbitCamera::Pan(const vec2& deltaPan, float deltaTime) {
vec3 right(m_matWorld._11, m_matWorld._12, m_matWorld._13);

// Pan X axis in local space
target = target - (right * (delataPan.x * panSpeed.x * deltaTime));
target = target - (right * (deltaPan.x * panSpeed.x * deltaTime));
// Pan Y Axis in global space
target = target + (vec3(0, 1, 0) * (delataPan.y * panSpeed.y * deltaTime));
target = target + (vec3(0, 1, 0) * (deltaPan.y * panSpeed.y * deltaTime));

// Reset zoom to allow infinate zooming after a motion
// This part of the code is not in the book!
Expand Down
2 changes: 1 addition & 1 deletion Code/Camera.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class OrbitCamera : public Camera {

void Rotate(const vec2& deltaRot, float deltaTime);
void Zoom(float deltaZoom, float deltaTime);
void Pan(const vec2& delataPan, float deltaTime);
void Pan(const vec2& deltaPan, float deltaTime);

void Update(float dt);
float ClampAngle(float angle, float min, float max);
Expand Down