chore: Separate structable into separate repository#1145
Merged
Conversation
Owner
gtema
commented
Apr 13, 2025
gtema
commented
- feat: Introduce dedicated structable crate
- chore: Separate structable into separate repository
It is not possible to implement StructTable trait for Vec since trait outside of the place where StructTable trait is defined due to the orphan rules constraint. Reasonable possibility is to rework StructTable trait to return headers, data row with a function combining those.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Creation of openstack_types crate uncovered an issue with the place where StructTable trait is being defined (orphan rule). In order to solve this the interface of StructTable should be changed and we also need to introduce `structable` crate defining this interface. It makes no sense anymore to host those 2 crates here. So drop them (keeping history).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.