Conversation
5a3a2e3 to
3e4dc16
Compare
It was intended to run tests with the MSRV and not the clippy. Since clippy format changes between releases it is not correct to check if the code formatted with newer clippy passed old clippy. It is relevant for tests though. Sadly we can't even parse the workspace with the 1.76 as declared supported by openstack_sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was intended to run tests with the MSRV and not the clippy. Since
clippy format changes between releases it is not correct to check if the
code formatted with newer clippy passed old clippy. It is relevant for
tests though.