glib: Add upgrade_or_insert{_with} to WeakRefs#1249
Open
ZanderBrown wants to merge 1 commit intogtk-rs:mainfrom
Open
glib: Add upgrade_or_insert{_with} to WeakRefs#1249ZanderBrown wants to merge 1 commit intogtk-rs:mainfrom
ZanderBrown wants to merge 1 commit intogtk-rs:mainfrom
Conversation
Avoids some boilerplate when implementing things like single-window apps, where you don't really care if the object was already set, you just need an object
sdroege
reviewed
Dec 12, 2023
| /// If the stored object was already destroyed or no object was set, the | ||
| /// reference is updated to the result of `f`, which is then returned | ||
| #[inline] | ||
| pub fn upgrade_or_insert_with<F>(&self, f: F) -> T |
Member
There was a problem hiding this comment.
This is unfortunately racy if called from multiple threads at once. That at least should be documented.
Contributor
Author
There was a problem hiding this comment.
Hmm, yes. I suppose we can't do much about that without new upstream API? bother.
Member
|
what is left to be done here? the new APIs looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids some boilerplate when implementing things like single-window apps, where you don't really care if the object was already set, you just need an object