0.20 backports #1506
Merged
0.20 backports #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss::Instance` This defaults to `std::ffi::c_void` but can be used to provide a newtype wrapper around it instead for additional type-safety in FFI code. Fixes gtk-rs#1485
Interfaces can't carry any data themselves.
While this method consumes a given `VariantDict`, the underlying object could still be accessed through other clones because of the reference counted clone semantics.
All that is guaranteed about them is that they give the correct order for the original strings when passed to strcmp(). Also add a separate integration test for this that calls setlocale() to get the default system locale. This makes sure that not just the "C" locale is selected, which returns literally the same string as collation key. Fixes gtk-rs#1504
pbor
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.