Safely and correctly convert InetAddress to IpAddr #1536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes use of unsafe code for conversion and implicitly fixes endianess issues in conversion. Fixes #1535
swsnr
changed the title
|
I can't make sense of the CI failure; any pointers? |
|
The size mismatch is because the .gir files don't match the installed GLib version anymore. Don't worry about that, I'll take care of it. |
sdroege
approved these changes
Oct 14, 2024
sdroege
added
the
needs-backport
sdroege
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of unsafe code for conversion and implicitly fixes endianess
issues in conversion.
Fixes #1535