-
-
Notifications
You must be signed in to change notification settings - Fork 131
Deduplicate metadata for structured logging #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sdroege This adds a test for the log impl and removes the duplicated metadata by avoiding the |
@sdroege I'd like to point out that changed the pipeline to hopefully include the |
This removes redundant file, line, and function fields. Fixes #1537
Yeah packages are automatically updated there and one update requires changes in the tests. I hope to get to fixing this some time this week. Sorry for the trouble! |
@sdroege No worries, didn't affect me much, as I can just run tests locally. Just wanted to point the one part of this PR I'm not entirely sure about 😇 |
It looks correct. I'll fix it if it isn't :) |
Thanks for merging 🙏 |
Closes #1537