Skip to content

Conversation

swsnr
Copy link
Contributor

@swsnr swsnr commented Oct 17, 2024

Closes #1537

@swsnr swsnr marked this pull request as ready for review October 17, 2024 09:46
@swsnr
Copy link
Contributor Author

swsnr commented Oct 17, 2024

@sdroege This adds a test for the log impl and removes the duplicated metadata by avoiding the log_structured! macro.

@swsnr
Copy link
Contributor Author

swsnr commented Oct 17, 2024

@sdroege I'd like to point out that changed the pipeline to hopefully include the log feature so as to run the new test on Github actions. However, since the pipeline didn't pass in the first place (it's even broken on master), and is somewhat complex, the change to the Github workflow is more of an educated guess than actually understanding what I did there 😇

@sdroege
Copy link
Member

sdroege commented Oct 17, 2024

since the pipeline didn't pass in the first place (it's even broken on master)

Yeah packages are automatically updated there and one update requires changes in the tests. I hope to get to fixing this some time this week. Sorry for the trouble!

@sdroege sdroege self-requested a review October 17, 2024 10:44
@swsnr
Copy link
Contributor Author

swsnr commented Oct 17, 2024

@sdroege No worries, didn't affect me much, as I can just run tests locally. Just wanted to point the one part of this PR I'm not entirely sure about 😇

@sdroege
Copy link
Member

sdroege commented Oct 17, 2024

It looks correct. I'll fix it if it isn't :)

@sdroege sdroege merged commit 722f437 into gtk-rs:master Oct 17, 2024
23 of 48 checks passed
@swsnr swsnr deleted the 1537-deduplicate-metadata branch October 18, 2024 10:10
@swsnr
Copy link
Contributor Author

swsnr commented Oct 18, 2024

Thanks for merging 🙏

@sdroege sdroege added the backported PR was backported to the current stable branch label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported PR was backported to the current stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] GLib structured logger duplicates CODE_FILE, CODE_LINE, and CODE_FUNC

2 participants