Skip to content

Conversation

erer1243
Copy link
Contributor

@erer1243 erer1243 commented Oct 20, 2024

cairo currently does not compile when using xcb and not using glib, because crate::Borrowed is not imported but is used. This fixes that.

> cd cairo/
> cargo c --no-default-features --features=xcb
error[E0412]: cannot find type `Borrowed` in this scope
  --> cairo/src/xcb.rs:49:71
   |
49 |     pub unsafe fn from_raw_borrow(ptr: *mut ffi::xcb_connection_t) -> Borrowed<XCBConnection> {
   |                                                                       ^^^^^^^^ not found in this scope
   |
help: consider importing this struct through its public re-export
   |
5  + use crate::Borrowed;
   |
<same error about 10 other times>

@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Oct 20, 2024
@sdroege sdroege merged commit 6717d2e into gtk-rs:master Oct 20, 2024
48 checks passed
@erer1243 erer1243 deleted the xcb_no_glib_borrowed branch October 21, 2024 02:18
@sdroege sdroege added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported PR was backported to the current stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants