Skip to content

glib: Add unimplemented diagnostic to IsA linking to the wrapper macro #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

glib: Add unimplemented diagnostic to IsA linking to the wrapper macro #1552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions glib/src/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ pub unsafe trait ObjectType:
///
/// The trait can only be implemented if the appropriate `ToGlibPtr`
/// implementations exist.
#[diagnostic::on_unimplemented(
message = "the trait `glib::object::IsA<{T}>` is not implemented for `{Self}`",
label = "requires `{Self}` to be a GObject that can be statically cast to `{T}`",
note = "if this is your own object, use the `glib::wrapper!` macro to implement this trait: https://gtk-rs.org/gtk-rs-core/stable/latest/docs/glib/macro.wrapper.html"
)]
pub unsafe trait IsA<T: ObjectType>:
ObjectType + Into<T> + AsRef<T> + std::borrow::Borrow<T>
{
Expand Down
Loading