Add some quality-of-life gdbus helpers #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
commented
Oct 31, 2024
|
Accidentally committed some left over change, I'll fix this tomorrow. |
|
@sdroege Pipeline passes now, but the question about the name still stands... should I rename the method? |
This trait represents a parsed method call with deserialized arguments, to abstract over call parsing. Then add new registration builder helpers to register method calls with a simplified callback which receives parsed arguments, and can optionally return an async result.
bilelmoussaoui
approved these changes
Nov 2, 2024
bilelmoussaoui
added
the
needs-backport
|
Thank you for reviewing and merging 🙏 |
sdroege
reviewed
Nov 30, 2024
| glib::timeout_future(Duration::from_secs(delay as u64)).await; | ||
| let greet = format!("Hello {name} after {delay} seconds!"); | ||
| println!("{greet}"); | ||
| Ok(Some(greet.to_variant())) |
There was a problem hiding this comment.
We should probably also figure out a way to make the return value more type safe
There was a problem hiding this comment.
Type safety as in "the return value matches the signature of the Dbus interface"?
There was a problem hiding this comment.
Yes. Maybe the structs in the enum need to implement a trait with an associated type for that, or so. I think that would all require a bit of reorganization though
sdroege
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper to return a standard result type from an invocation, automatically wrapping the return value into a tuple if it isn't a tuple yet.
Add another helper to return an async result from a future.
Update the gdbus example to demo the new async helper, and show how to simplify parameter handling with auto-derived variant structs.