gio: Use manual env: &[OsString] parameter for SubprocessLauncher::set_environ #1642
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Jan 28, 2025
pjungkamp
force-pushed
the
gio/subprocess-launcher
branch
from
0622d63 to
1d51e13
Compare
pjungkamp
changed the title
os_string for SubprocessLauncher::set_environ env parameter
sdroege
reviewed
Jan 28, 2025
pjungkamp
force-pushed
the
gio/subprocess-launcher
branch
from
1d51e13 to
037ae39
Compare
sdroege
approved these changes
Jan 29, 2025
sdroege
added
the
needs-backport
sdroege
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1638
This should be better than the existing bindings, but changing the API to something that accepts
&[impl AsRef<OsStr>]would be preferable.