Re-export CancelledHandlerId #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hawk777
force-pushed
the
export-cancelled-handler-id
branch
from
a893bfe to
6844a2d
Compare
This type is effectively public, because it’s returned by `Cancellable::connect_cancelled`, but because it’s not re-exported it can’t be named, making it awkward to e.g. save it in a struct field. Fixes gtk-rsGH-1649.
Hawk777
force-pushed
the
export-cancelled-handler-id
branch
from
6844a2d to
a0a10e9
Compare
|
I think this is ready for review; there is one CI check failing but it’s pointing nowhere near anything I modified and I don’t understand what it’s complaining about. |
bilelmoussaoui
approved these changes
Feb 10, 2025
sdroege
added
the
needs-backport
sdroege
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is effectively public, because it’s returned by
Cancellable::connect_cancelled, but because it’s not re-exported it can’t be named, making it awkward to e.g. save it in a struct field.Fixes GH-1649.