Skip to content

Conversation

BiagioFesta
Copy link
Contributor

@BiagioFesta BiagioFesta commented Feb 24, 2025

Fixes: #1663

For reviewers to focus on

Beside "sed changes", manual changes also include:

  • impl IntoGlibPtr<*mut c_char> for GString requires inner unsafe block as calling extern "C" functions
  • pub unsafe trait RefCounted::into_raw also changed removing unsafe requirement.
  • This is a API (breaking/major) change

@sdroege sdroege merged commit 2967438 into gtk-rs:main Feb 25, 2025
47 of 48 checks passed
@sdroege
Copy link
Member

sdroege commented Feb 25, 2025

Thanks!

@BiagioFesta BiagioFesta deleted the wip/bfesta/remove-unsafe-to-ptr branch April 18, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Remove unsafe for into pointer conversion (rust edition 2024)

2 participants