gio: Use OwnedSocket / BorrowedSocket for Windows APIs on GSocket
#1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
force-pushed
the
windows-safe-io-socket
branch
from
f12700c to
04d17cd
Compare
|
CI failure is a false positive compiler error with latest nightly... |
sdroege
force-pushed
the
windows-safe-io-socket
branch
from
04d17cd to
7022a50
Compare
A6GibKm
reviewed
Apr 5, 2025
sdroege
commented
Apr 5, 2025
| self.to_raw_none(), | ||
| mime_type.as_ptr(), | ||
| &data_ptr, | ||
| &mut data_ptr, |
There was a problem hiding this comment.
Actually not a false positive. That code was completely broken
sdroege
force-pushed
the
windows-safe-io-socket
branch
from
87fcc32 to
cfd7fef
Compare
|
CI finally passing |
A6GibKm
reviewed
Apr 6, 2025
|
|
||
| let n_channels = if has_alpha { 4 } else { 3 }; | ||
| let last_row_len = width * ((n_channels * bits_per_sample + 7) / 8); | ||
| let last_row_len = width * (n_channels * bits_per_sample).div_ceil(8); |
There was a problem hiding this comment.
This is missing a 7 isn't it?
There was a problem hiding this comment.
There was a +7 before and that change seemed unrelated to clippy fixes.
There was a problem hiding this comment.
That (x + 7) / 8 is the same as dividing by 8 and rounding up (which is what div_ceil() does)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @A6GibKm