Implement gio::File::set_attribute #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
May 3, 2025
sdroege
reviewed
May 3, 2025
fbrouille
force-pushed
the
g_file_set_attribute
branch
3 times, most recently
from
91b8c29 to
2deef12
Compare
sdroege
reviewed
May 7, 2025
sdroege
reviewed
May 7, 2025
sdroege
reviewed
May 7, 2025
sdroege
reviewed
May 7, 2025
sdroege
reviewed
May 7, 2025
Member
|
i guess you could also easily add https://docs.gtk.org/gio/method.FileInfo.set_attribute.html ? |
fbrouille
force-pushed
the
g_file_set_attribute
branch
from
2deef12 to
ef65bb7
Compare
Contributor
Author
|
sure, when we'll be aligned |
fbrouille
force-pushed
the
g_file_set_attribute
branch
from
ef65bb7 to
e53d619
Compare
sdroege
reviewed
May 8, 2025
sdroege
reviewed
May 8, 2025
sdroege
reviewed
May 8, 2025
fbrouille
force-pushed
the
g_file_set_attribute
branch
from
e53d619 to
7520fd3
Compare
sdroege
reviewed
May 13, 2025
sdroege
reviewed
May 13, 2025
sdroege
previously approved these changes
May 13, 2025
Member
sdroege
left a comment
sdroege
left a comment
There was a problem hiding this comment.
Looks good to me then, is there any other place where this new type can be used?
Member
@sdroege see ^ |
Contributor
Author
done |
fbrouille
force-pushed
the
g_file_set_attribute
branch
from
01585a6 to
427d793
Compare
| // Take a look at the license at the top of the repository in the LICENSE file. | ||
|
|
||
| use std::{cell::RefCell, ffi::CStr, mem, pin::Pin, ptr}; | ||
| use std::{cell::RefCell, mem, pin::Pin, ptr}; |
Contributor
Author
There was a problem hiding this comment.
Added to the other commit because issue is for FileInfo
fbrouille
force-pushed
the
g_file_set_attribute
branch
from
427d793 to
25eb318
Compare
sdroege
approved these changes
May 20, 2025
Member
|
If you rebase this on top of #1724 (i.e. latest |
Signed-off-by: fbrouille <[email protected]>
Closes gtk-rs#40 Signed-off-by: fbrouille <[email protected]>
Member
|
Actually let me just do that now. |
sdroege
force-pushed
the
g_file_set_attribute
branch
from
25eb318 to
ed44365
Compare
Contributor
Author
|
thank you for all your remarks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.