Document requirement for explicit default in Enum properties
#1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozwock
changed the title
glib::Enum propertiesEnum properties
nozwock
force-pushed
the
document-enum-macro
branch
2 times, most recently
from
543f38e to
23c02ea
Compare
sdroege
reviewed
Jun 11, 2025
nozwock
force-pushed
the
document-enum-macro
branch
from
23c02ea to
914526f
Compare
|
Made some changes. (Mentioning it separately since I think no notifications are sent for commits?) |
sdroege
previously approved these changes
Jun 12, 2025
sdroege
reviewed
Jun 12, 2025
|
Also, let me know if there's a need to squash these commits, and/or to update the PR's title/body, etc. |
sdroege
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Propertiesmacro with enum types that deriveEnum, the default value must be explicitly set using#[property(builder(...))].