Add cargo feature for quartz surface #1753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Prince we use a custom build of Cairo that is built with a shared configuration across platforms. This configuration does not enable Quartz surfaces, since we don't use them. When trying to use this build of cairo from cairo-rs on macOS we get these linker errors:
This PR introduces a
quartz-surface
cargo feature to make it possible to compile cairo-rs without Quartz surfaces.As it stands this will be a breaking change from the status quo as Quartz surfaces will become opt-in. I'm aware that this may not be desired, but it does match the win32 behaviour. If this is not desired I can add it to the
default
features.