Skip to content

glib: Fully transfer ownership in <Value as From<Vec<GString>>>::from #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

glib: Fully transfer ownership in <Value as From<Vec<GString>>>::from #1759

merged 1 commit into from
Jun 30, 2025

Conversation

yvt
Copy link
Contributor

@yvt yvt commented Jun 30, 2025

g_value_take_boxed takes full ownership of a provided object, so we should convert GStrings into *mut c_chars by into_glib_ptr.

Fixes the segfault that occurs when releasing the Value created by converting from Vec<GString>.

@yvt
glib: Fully transfer ownership in <Value as From<Vec<GString>>>::from
5937980 
`g_value_take_boxed` takes a full ownership of a provided object, so we
should convert `GString`s by `into_glib_ptr`.
@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Jun 30, 2025
@sdroege sdroege merged commit 9c05265 into gtk-rs:main Jun 30, 2025
48 checks passed
@yvt yvt deleted the fix-value-from-vec-gstring branch June 30, 2025 15:41
@sdroege sdroege added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdroege sdroege sdroege approved these changes

Assignees

No one assigned

Labels

backported PR was backported to the current stable branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yvt @sdroege