Skip to content

glib: Fix new clippy warnings #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

glib: Fix new clippy warnings #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3981bb
glib: Fix new clippy warnings
sdroege Aug 5, 2025
2ecd1dc
glib: Only build regex compiletests if the corresponding feature is e…
sdroege Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions glib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ gio = ["gio-sys"]
name = "subclass_compiletest"
required-features = ["compiletests"]

[[test]]
name = "regex_compiletest"
required-features = ["compiletests"]

[[bench]]
name = "gstring"
harness = false
Expand Down
6 changes: 3 additions & 3 deletions glib/src/value_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ impl ValueArray {
b: ffi::gconstpointer,
func: ffi::gpointer,
) -> i32 {
let func = func as *mut &mut (dyn FnMut(&Value, &Value) -> Ordering);
let func = func as *mut &mut dyn FnMut(&Value, &Value) -> Ordering;

let a = &*(a as *const Value);
let b = &*(b as *const Value);
Expand All @@ -127,9 +127,9 @@ impl ValueArray {
}
unsafe {
let mut func = compare_func;
let func_obj: &mut (dyn FnMut(&Value, &Value) -> Ordering) = &mut func;
let func_obj: &mut dyn FnMut(&Value, &Value) -> Ordering = &mut func;
let func_ptr =
&func_obj as *const &mut (dyn FnMut(&Value, &Value) -> Ordering) as ffi::gpointer;
&func_obj as *const &mut dyn FnMut(&Value, &Value) -> Ordering as ffi::gpointer;

gobject_ffi::g_value_array_sort_with_data(
self.to_glib_none_mut().0,
Expand Down
Loading