Skip to content

Conversation

zeroy0410
Copy link

fix #1805

@zeroy0410 zeroy0410 closed this Sep 5, 2025
@sdroege
Copy link
Member

sdroege commented Sep 5, 2025

You don't have to close a PR if you just want to update it. Push new commits to an existing PR or even change commits and git push --force the changed commits into it

Comment on lines 100 to 102
[[object.function.parameter]]
name = "cached_iter"
const = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can drop those

Comment on lines +378 to +386
[[object.function]]
name = "intersect_box"
manual = true # fix issue 1805
[[object.function]]
name = "intersect_sphere"
manual = true # fix issue 1805
[[object.function]]
name = "intersect_triangle"
manual = true # fix issue 1805
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[object.function]]
name = "intersect_box"
manual = true # fix issue 1805
[[object.function]]
name = "intersect_sphere"
manual = true # fix issue 1805
[[object.function]]
name = "intersect_triangle"
manual = true # fix issue 1805
[[object.function]]
pattern = "intersect_(box|sphere|triangle)"
manual = true # Handle no intersection cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Comprehensive Report] Multiple Soundness and Logical Issues Found in Rust FFI Wrappers

3 participants