Skip to content

gio: Mark DBusInterface.get_info's return value as nullable #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gio: Mark DBusInterface.get_info's return value as nullable #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gio/Gir.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,10 @@ status = "generate"
[[object.function]]
name = "dup_object"
rename = "get"
[[object.function]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should send this upstream instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4856

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whaaa you were so fast 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do that so often, it's part of muscle memory already 🤣

name = "get_info"
[object.function.return]
nullable = true

[[object]]
name = "Gio.DBusInterfaceInfo"
Expand Down
2 changes: 1 addition & 1 deletion gio/src/auto/dbus_interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pub trait DBusInterfaceExt: IsA<DBusInterface> + 'static {

#[doc(alias = "g_dbus_interface_get_info")]
#[doc(alias = "get_info")]
fn info(&self) -> DBusInterfaceInfo {
fn info(&self) -> Option<DBusInterfaceInfo> {
unsafe {
from_glib_none(ffi::g_dbus_interface_get_info(
self.as_ref().to_glib_none().0,
Expand Down
Loading