glib: Fix Regex::match API
#1849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors are independent of the return value, which signals whether there was a match or not. No match is not an error. Also a match info is always provided unless there is an error. Fixes gtk-rs#1848
sdroege
added
the
needs-backport
bilelmoussaoui
approved these changes
Nov 21, 2025
sdroege
commented
Nov 21, 2025
| start_position: i32, | ||
| match_options: RegexMatchFlags, | ||
| ) -> Result<MatchInfo<'input>, crate::Error> { | ||
| ) -> Result<(bool, MatchInfo<'input>), crate::Error> { |
Member
Author
There was a problem hiding this comment.
This is a breaking API change but the current API makes little sense.
If we want to preserve the API we could omit the bool return value and instead require the caller to check match_info.matches() which provides the very same information. It's a bit redundant right now but closer to the C API.
@bilelmoussaoui Any opinions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.