Draft: Use Into<Option<_>> in argument position where applicable#1929
Open
fengalin wants to merge 7 commits intogtk-rs:mainfrom
Open
Draft: Use Into<Option<_>> in argument position where applicable#1929fengalin wants to merge 7 commits intogtk-rs:mainfrom
Into<Option<_>> in argument position where applicable#1929fengalin wants to merge 7 commits intogtk-rs:mainfrom
Conversation
fengalin
force-pushed
the
more-into-option-args
branch
from
073dc8b to
86ba457
Compare
fengalin
force-pushed
the
more-into-option-args
branch
from
86ba457 to
5e84037
Compare
fengalin
commented
Dec 2, 2024
gtk4/src/auto/about_dialog.rs
Outdated
| @@ -810,7 +828,7 @@ impl AboutDialogBuilder { | |||
|
|
|||
| pub fn logo(self, logo: &impl IsA<gdk::Paintable>) -> Self { | |||
Contributor
Author
There was a problem hiding this comment.
I took the liberty to align the conversion in Builder setters with what was already in use for the regular setters. I think the discrepancy was due to code duplication. The same code path is now used for both.
fengalin
force-pushed
the
more-into-option-args
branch
from
5e84037 to
8e7fb3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the gir PR for details.
TODO