Adjust install of ashpd to avoid tokio
#2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 0.10 `ashpd` has shipped with the `tokio` feature enabled by default. This slightly undermines this section of the book where the author is discussing non-tokio ways to run async code. This commit adjusts the command for adding `ashpd` to exclude `tokio` and use the previously expected `async-std` feature instead. Without this change, the example code compiles but panics with a `there is no reactor running` message. With this change, the example code runs successfully.
|
Thanks @Jwashton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 0.10
ashpdhas shipped with thetokiofeature enabled by default. This slightly undermines this section of the book where the author is discussing non-tokio ways to run async code.This commit adjusts the command for adding
ashpdto excludetokioand use the previously expectedasync-stdfeature instead.Without this change, the example code compiles but panics with a
there is no reactor runningmessage. With this change, the example code runs successfully.