fix(event_controller): set_static_name UAF fixed, name now has static lifetime #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @bilelmoussaoui |
gtk4/src/event_controller.rs
Outdated
Comment on lines
3
to
8
| #[allow(unused_imports)] | ||
| use glib::translate::*; | ||
|
|
||
| use crate::prelude::*; | ||
| #[allow(unused_imports)] | ||
| use crate::{ffi, EventController}; |
There was a problem hiding this comment.
Suggested change
| #[allow(unused_imports)] | |
| use glib::translate::*; | |
| use crate::prelude::*; | |
| #[allow(unused_imports)] | |
| use crate::{ffi, EventController}; | |
| #[cfg(feature = "v4_8")] | |
| use glib::translate::*; | |
| #[cfg(feature = "v4_8")] | |
| use crate::{ffi, prelude::*, EventController}; |
There was a problem hiding this comment.
prelude::* needs to be in scope in order for IsA<EventController> to work
gtk4/Gir.toml
Outdated
| [[object.function]] | ||
| name = "set_static_name" | ||
| manual = true # to make use of a static lifetimed string | ||
| doc_trait_name = "EventControllerExtManual" |
There was a problem hiding this comment.
Suggested change
| doc_trait_name = "EventControllerExtManual" |
|
Please rebase for the CI to pass. |
|
& squash the commits into a single one. |
otaxhu
force-pushed
the
set_static_name-UAF
branch
from
dbc1b29 to
153b159
Compare
bilelmoussaoui
approved these changes
May 16, 2025
sdroege
reviewed
May 17, 2025
|
PR converted to draft due what @sdroege commented #2056 (comment) |
Co-authored-by: Sebastian Dröge <[email protected]>
sdroege
added a commit
to sdroege/gtk4-rs
that referenced
this pull request
Jun 20, 2025
…rs#2056) * fix(event_controller): set_static_name UAF fixed, name now has static lifetime * fix(event_controller): using GStr instead of str Co-authored-by: Sebastian Dröge <[email protected]> --------- Co-authored-by: Sebastian Dröge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2053